chore: migrate from Prettier to oxfmt for code formatting#11824
Open
yangshun wants to merge 5 commits intofacebook:mainfrom
Open
chore: migrate from Prettier to oxfmt for code formatting#11824yangshun wants to merge 5 commits intofacebook:mainfrom
yangshun wants to merge 5 commits intofacebook:mainfrom
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Great Idea. Was searching for something like this. |
slorber
added
pr: maintenance
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Collaborator
|
@yangshun let me know if you want to update this PR. Now that we upgraded node it should pass CI. |
Contributor
Author
|
Sorry I dropped the ball on this, I'll update this PR within the next few days. Or if you want to take over go ahead as well. |
Replace prettier invocation in per-package build scripts and refresh yarn.lock after switching from prettier to oxfmt.
Contributor
Author
|
@slorber updated to latest Oxlint and rebased against
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.oxfmtrc.jsonconfiguration and remove.prettierrc/.prettierignoreTest plan
oxfmtformats all files correctlyNotes on CI
pull-requests: writeto post the sticky comment); the audit itself ran successfully.